linux-kernel - Re: [PATCH] mei: fix incorrect logical operator in if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fbefeafe-50d6-2c1f-aecb-f334c9e555e6@canonical.com>
Date:   Wed, 20 Dec 2017 09:10:14 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     "Winkler, Tomas" <tomas.winkler@...el.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mei: fix incorrect logical operator in if statement

On 20/12/17 08:58, Winkler, Tomas wrote:
> 
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The current expression using the || operator is always true because
>> dev->dev_state cannot be equal to two different values at the same time.
>> Fix this by replacing the || with &&.
>>
>> Detected by CoverityScan, CID#1463042 ("Constant expression result")
>>
>> Fixes: 8d52af6795c0 ("mei: speed up the power down flow")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Shame on me.

No worries, that's why I run static analysis linux-next.

> Ack.
> Tomas
> 
>> ---
>>  drivers/misc/mei/hw-me.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c index
>> 0b21f9ec00f5..334ab02e1de2 100644
>> --- a/drivers/misc/mei/hw-me.c
>> +++ b/drivers/misc/mei/hw-me.c
>> @@ -1261,7 +1261,7 @@ irqreturn_t mei_me_irq_thread_handler(int irq,
>> void *dev_id)
>>  			break;
>>
>>  		if (rets &&
>> -		    (dev->dev_state != MEI_DEV_RESETTING ||
>> +		    (dev->dev_state != MEI_DEV_RESETTING &&
>>  		     dev->dev_state != MEI_DEV_POWER_DOWN)) {
>>  			dev_err(dev->dev, "mei_irq_read_handler ret =
>> %d.\n",
>>  						rets);
>> --
>> 2.14.1
> 
> N�����r��y���b�X��ǧv�^�)޺{.n�+���z�ޖ6���+�)���w*.jg���.�����ݢj/���z�ޖ��2�ޙ���&�)ߡ�a����.�G���h�.�j:+v���w�٥
>