linux-kernel - Re: [PATCH] tools/power: Don't make man pages executable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e94456c7-cd84-2fa0-f1c9-e7b883ce73cc@intel.com>
Date:   Wed, 20 Dec 2017 02:36:03 +0100
From:   "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:     Laura Abbott <labbott@...hat.com>
Cc:     Len Brown <len.brown@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/power: Don't make man pages executable

On 12/20/2017 1:36 AM, Laura Abbott wrote:
> On 12/19/2017 03:48 PM, Rafael J. Wysocki wrote:
>> On 12/19/2017 8:54 PM, Laura Abbott wrote:
>>> rpm-lint flagged these as being executable:
>>>
>>> kernel-tools.x86_64: W: spurious-executable-perm 
>>> /usr/share/man/man8/turbostat.8.gz
>>> kernel-tools.x86_64: W: spurious-executable-perm 
>>> /usr/share/man/man8/x86_energy_perf_policy.8.gz
>>>
>>> Fix this
>>>
>>> Signed-off-by: Laura Abbott <labbott@...hat.com>
>>
>> Please CC PM stuff to linux-pm (which makes it easier to handle).
>>
>
> Neither of these are listed in MAINTAINERS so I missed sending to
> linux-pm. I'll remember for next time, do you want me to resend
> for tracking?
>

Yes, please.

Thanks,
Rafael


>
>>> ---
>>>   tools/power/x86/turbostat/Makefile              | 2 +-
>>>   tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-
>>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tools/power/x86/turbostat/Makefile 
>>> b/tools/power/x86/turbostat/Makefile
>>> index a9bc914a8fe8..2ab25aa38263 100644
>>> --- a/tools/power/x86/turbostat/Makefile
>>> +++ b/tools/power/x86/turbostat/Makefile
>>> @@ -25,4 +25,4 @@ install : turbostat
>>>       install -d  $(DESTDIR)$(PREFIX)/bin
>>>       install $(BUILD_OUTPUT)/turbostat 
>>> $(DESTDIR)$(PREFIX)/bin/turbostat
>>>       install -d  $(DESTDIR)$(PREFIX)/share/man/man8
>>> -    install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
>>> +    install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
>>> diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile 
>>> b/tools/power/x86/x86_energy_perf_policy/Makefile
>>> index 2447b1bbaacf..f4534fb8b951 100644
>>> --- a/tools/power/x86/x86_energy_perf_policy/Makefile
>>> +++ b/tools/power/x86/x86_energy_perf_policy/Makefile
>>> @@ -24,5 +24,5 @@ install : x86_energy_perf_policy
>>>       install -d  $(DESTDIR)$(PREFIX)/bin
>>>       install $(BUILD_OUTPUT)/x86_energy_perf_policy 
>>> $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
>>>       install -d  $(DESTDIR)$(PREFIX)/share/man/man8
>>> -    install x86_energy_perf_policy.8 
>>> $(DESTDIR)$(PREFIX)/share/man/man8
>>> +    install -m 644 x86_energy_perf_policy.8 
>>> $(DESTDIR)$(PREFIX)/share/man/man8
>>
>>
>> Thanks,
>>
>> Rafael
>>
>>
>