linux-kernel - Re: [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171220102955.GA941@red-moon>
Date:   Wed, 20 Dec 2017 10:29:55 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Keerthy <j-keerthy@...com>
Cc:     Vignesh R <vigneshr@...com>, Bjorn Helgaas <bhelgaas@...gle.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        linux-omap@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static

On Fri, Dec 01, 2017 at 04:53:14PM +0000, Lorenzo Pieralisi wrote:
> On Fri, Dec 01, 2017 at 10:43:53AM +0530, Keerthy wrote:
> > 
> > 
> > On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
> > > Declare dra7xx_pcie_shutdown() as a static function as its not used
> > > elsewhere.
> > 
> > Seems like the below version that had static version was not taken:
> > 
> > https://patchwork.kernel.org/patch/10052579/
> 
> It looks like I can drop the patch above then - let me know if
> that's ok.

I would appreciate some feedback; I assume that dropping the patch above
and applying the patch in $SUBJECT is what you expect, if there is a
problem with that please manifest yourselves.

Lorenzo

> Thanks,
> Lorenzo
> 
> > So for this patch:
> > 
> > Reviewed-by: Keerthy <j-keerthy@...com>
> > 
> > > 
> > > Signed-off-by: Vignesh R <vigneshr@...com>
> > > ---
> > >  drivers/pci/dwc/pci-dra7xx.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> > > index 59e8de34cec6..b9db442af793 100644
> > > --- a/drivers/pci/dwc/pci-dra7xx.c
> > > +++ b/drivers/pci/dwc/pci-dra7xx.c
> > > @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
> > >  }
> > >  #endif
> > >  
> > > -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> > > +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
> > >  {
> > >  	struct device *dev = &pdev->dev;
> > >  	struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> > >