linux-kernel - Re: [PATCH v3 1/2] acpi: thermal: initialize tz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Dec 2017 12:27:58 +0100
From:   Enric Balletbo Serra <eballetbo@...il.com>
To:     Zhang Rui <rui.zhang@...el.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Sameer Nanda <snanda@...omium.org>
Subject: Re: [PATCH v3 1/2] acpi: thermal: initialize tz_enabled to 1

Hi Rui,

2017-07-04 3:43 GMT+02:00 Zhang Rui <rui.zhang@...el.com>:
> On Mon, 2017-07-03 at 23:08 +0200, Rafael J. Wysocki wrote:
>> On Mon, Jul 3, 2017 at 10:00 AM, Enric Balletbo i Serra
>> <enric.balletbo@...labora.com> wrote:
>> >
>> > From: Sameer Nanda <snanda@...omium.org>
>> >
>> > In the acpi_thermal_add path, acpi_thermal_get_info gets called
>> > before
>> > acpi_thermal_register_thermal_zone.  Since tz_enabled was getting
>> > set to
>> > 1 only in acpi_thermal_register_thermal_zone, acpi_thermal_get_info
>> > ended up disabling thermal polling.
>> >
>> > Moved setting of tz_enabled to 1 into acpi_thermal_add itself.
>> >
>> > Signed-off-by: Sameer Nanda <snanda@...omium.org>
>> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com
>> > >
>> > ---
>> > Changes since v2:
>> >  - Zhang Rui:
>> >    - Make sure tz->tz_enabled is set properly before registering
>> > the zone.
>> >
>> > Changes since v1:
>> >  - This patch is new from v1 [1]
>> >
>> >  [1] https://patchwork.kernel.org/patch/9804229/
>> >
>> >  drivers/acpi/thermal.c | 3 +--
>> >  1 file changed, 1 insertion(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
>> > index 1d0417b..cd0fe92 100644
>> > --- a/drivers/acpi/thermal.c
>> > +++ b/drivers/acpi/thermal.c
>> > @@ -930,8 +930,6 @@ static int
>> > acpi_thermal_register_thermal_zone(struct acpi_thermal *tz)
>> >         if (ACPI_FAILURE(status))
>> >                 return -ENODEV;
>> >
>> > -       tz->tz_enabled = 1;
>> > -
>> >         dev_info(&tz->device->dev, "registered as
>> > thermal_zone%d\n",
>> >                  tz->thermal_zone->id);
>> >         return 0;
>> > @@ -1088,6 +1086,7 @@ static int acpi_thermal_add(struct
>> > acpi_device *device)
>> >                 return -ENOMEM;
>> >
>> >         tz->device = device;
>> > +       tz->tz_enabled = 1;
>> >         strcpy(tz->name, device->pnp.bus_id);
>> >         strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
>> >         strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
>> > --
>> Rui,
>>
>> Can I just apply this, or do I need to work for a thermal core
>> update?
>>  In the latter case, can you take care of this one too, please?
>>
> Yes, I will take both of the patches.
>

Long time since I posted these patches but didn't land, I'm not sure
if you're waiting an action from me. Are fine ? Do you want me to
rebase it on top of mainline and resend?

Thanks,
 Enric

> thanks,
> rui
>
>> Thanks,
>> Rafael