linux-kernel - Re: [PATCH v3 1/1] eeprom: at24: convert magic numbers to structs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=McQThGRYqmbue8jw_uKQPicitQn6rNxZxo9+HYQ3UaYDw@mail.gmail.com>
Date:   Wed, 20 Dec 2017 17:37:51 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Sven Van Asbroeck <thesven73@...il.com>
Cc:     Sven Van Asbroeck <svenv@...x.com>,
        Sven Van Asbroeck <svendev@...x.com>,
        Wolfram Sang <wsa@...-dreams.de>, nsekhar@...com,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Javier Martinez Canillas <javier@...hile0.org>,
        Divagar Mohandass <divagar.mohandass@...el.com>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v3 1/1] eeprom: at24: convert magic numbers to structs.

2017-12-20 17:32 GMT+01:00 Sven Van Asbroeck <thesven73@...il.com>:
>>> +       { .compatible = "atmel,24c00", .data = &at24_data_24c00 },
>>
>> Add tabs here as well, seems like there's enough space in the line.
>
> There's not enough space in the line to line up the 24c1024 entry with
> the others. I'll revert to the formatting style that was there before.

I'm at 77 columns if I add a single tab after '.compatible = "atmel,24c1024"'.

It looks nice like this, so I prefer to keep it.

Thanks,
Bartosz Golaszewski