linux-kernel - Re: [PATCH AUTOSEL for 4.14 20/60] kbuild: re-order the code to not parse unnecessary variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171220171319.GA6541@kroah.com>
Date:   Wed, 20 Dec 2017 18:13:19 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     alexander.levin@...izon.com
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: Re: [PATCH AUTOSEL for 4.14 20/60] kbuild: re-order the code to not
 parse unnecessary variables

On Wed, Dec 13, 2017 at 01:55:15AM +0000, alexander.levin@...izon.com wrote:
> From: Masahiro Yamada <yamada.masahiro@...ionext.com>
> 
> [ Upstream commit 2c1f4f125159f10521944cea23e33a00fcf85ede ]
> 
> The top Makefile is divided into some sections such as mixed targets,
> config targets, build targets, etc.
> 
> When we build mixed targets, Kbuild just invokes submake to process
> them one by one.  In this case, compiler-related variables like CC,
> KBUILD_CFLAGS, etc. are unneeded.
> 
> Check what kind of targets we are building first, and parse variables
> for building only when necessary.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Signed-off-by: Sasha Levin <alexander.levin@...izon.com>
> ---
>  Makefile | 233 ++++++++++++++++++++++++++++++++-------------------------------
>  1 file changed, 118 insertions(+), 115 deletions(-)

While this is a "nice thing", I don't see how this is a good 4.14-stable patch.

It doesn't fix a bug, is really "big", and might make a build faster
(but does it even do that?)

So I'm going to drop this from the pull request you sent, thanks.

greg k-h