lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Dec 2017 18:18:31 +0100 From: Bartosz Golaszewski <brgl@...ev.pl> To: Sven Van Asbroeck <svendev@...x.com> Cc: Wolfram Sang <wsa@...-dreams.de>, nsekhar@...com, Sakari Ailus <sakari.ailus@...ux.intel.com>, Javier Martinez Canillas <javier@...hile0.org>, Divagar Mohandass <divagar.mohandass@...el.com>, devicetree <devicetree@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-i2c <linux-i2c@...r.kernel.org> Subject: Re: [PATCH v2 2/2] eeprom: at24: remove temporary fix for at24mac402 size. 2017-12-08 22:25 GMT+01:00 Sven Van Asbroeck <svendev@...x.com>: > The chip size passed via devicetree, i2c, or acpi device ids is > now no longer limited to a power of two. So the temporary > fix can be removed. > > Signed-off-by: Sven Van Asbroeck <svendev@...x.com> > --- > drivers/misc/eeprom/at24.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c > index c3759cb..e522350 100644 > --- a/drivers/misc/eeprom/at24.c > +++ b/drivers/misc/eeprom/at24.c > @@ -569,16 +569,6 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id) > dev_warn(&client->dev, > "page_size looks suspicious (no power of 2)!\n"); > > - /* > - * REVISIT: the size of the EUI-48 byte array is 6 in at24mac402, while > - * the call to ilog2() in AT24_DEVICE_MAGIC() rounds it down to 4. > - * > - * Eventually we'll get rid of the magic values altoghether in favor of > - * real structs, but for now just manually set the right size. > - */ > - if (chip.flags & AT24_FLAG_MAC && chip.byte_len == 4) > - chip.byte_len = 6; > - > if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C) && > !i2c_check_functionality(client->adapter, > I2C_FUNC_SMBUS_WRITE_I2C_BLOCK)) > -- > 1.9.1 > Applied, thanks!
Powered by blists - more mailing lists