lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 20 Dec 2017 11:10:05 -0700
From:   Jason Gunthorpe <>
To:     "Shaikh, Azhar" <>
Cc:     Javier Martinez Canillas <>,
        "" <>,
        James Ettle <>,
        Hans de Goede <>,
        Arnd Bergmann <>,
        Jarkko Sakkinen <>,
        Peter Huewe <>,
        Greg Kroah-Hartman <>,
        "" <>
Subject: Re: [PATCH 2/4] tpm: delete the TPM_TIS_CLK_ENABLE flag

On Wed, Dec 20, 2017 at 03:19:19PM +0000, Shaikh, Azhar wrote:
> >This flag is only used to warn if CLKRUN_EN wasn't disabled on Braswell
> >systems, but the only way this can happen is if the code is not correct.
> >
> >So it's an unnecessary check that just makes the code harder to read.
> This code was implemented as a suggestion from Jason on the previous patches. 

The concept was to be like ASSERT_RTNL, maybe it just needs a suitably
named static inline to addrress Javier's readability concerns?


Powered by blists - more mailing lists