linux-kernel - Re: [PATCH] drm/tegra: fix non-debugfs builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Dec 2017 19:59:52 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     David Airlie <airlied@...ux.ie>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/tegra: fix non-debugfs builds

On Mon, Dec 18, 2017 at 02:44:46PM +0100, Arnd Bergmann wrote:
> The new debugfs registration fails to build when CONFIG_DEBUGFS is
> disabled, because the drm_crtc structure is lacking a member in that
> configuration:
> 
> drivers/gpu/drm/tegra/dc.c: In function 'tegra_dc_late_register':
> drivers/gpu/drm/tegra/dc.c:1204:28: error: 'struct drm_crtc' has no member named 'debugfs_entry'
> 
> Without CONFIG_DEBUGFS, the rest of the function already degrades
> into nothing, so we just avoid the one assignment.
> 
> Fixes: b95800eeef09 ("drm/tegra: dc: Register debugfs in ->late_register()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/gpu/drm/tegra/dc.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

I don't think I replied, but I had applied this yesterday, so this
should be fixed in linux-next today.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)