lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1513799484-12505-4-git-send-email-amit.pundir@linaro.org> Date: Thu, 21 Dec 2017 01:21:23 +0530 From: Amit Pundir <amit.pundir@...aro.org> To: lkml <linux-kernel@...r.kernel.org>, linux-wireless@...r.kernel.org Cc: Suren Baghdasaryan <surenb@...gle.com>, Samuel Ortiz <sameo@...ux.intel.com>, Christophe Ricard <christophe.ricard@...il.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, John Stultz <john.stultz@...aro.org>, Dmitry Shmidt <dimitrysh@...gle.com>, Todd Kjos <tkjos@...gle.com>, Android Kernel Team <kernel-team@...roid.com> Subject: [RFC][PATCH 3/4] NFC: Fix possible memory corruption when handling SHDLC I-Frame commands From: Suren Baghdasaryan <surenb@...gle.com> When handling SHDLC I-Frame commands "pipe" field used for indexing into an array should be checked before usage. If left unchecked it might access memory outside of the array of size NFC_HCI_MAX_PIPES(127). Signed-off-by: Suren Baghdasaryan <surenb@...gle.com> Signed-off-by: Amit Pundir <amit.pundir@...aro.org> --- net/nfc/hci/core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/net/nfc/hci/core.c b/net/nfc/hci/core.c index ac8030c4bcf8..19cb2e473ea6 100644 --- a/net/nfc/hci/core.c +++ b/net/nfc/hci/core.c @@ -209,6 +209,11 @@ void nfc_hci_cmd_received(struct nfc_hci_dev *hdev, u8 pipe, u8 cmd, } create_info = (struct hci_create_pipe_resp *)skb->data; + if (create_info->pipe >= NFC_HCI_MAX_PIPES) { + status = NFC_HCI_ANY_E_NOK; + goto exit; + } + /* Save the new created pipe and bind with local gate, * the description for skb->data[3] is destination gate id * but since we received this cmd from host controller, we @@ -232,6 +237,11 @@ void nfc_hci_cmd_received(struct nfc_hci_dev *hdev, u8 pipe, u8 cmd, } delete_info = (struct hci_delete_pipe_noti *)skb->data; + if (delete_info->pipe >= NFC_HCI_MAX_PIPES) { + status = NFC_HCI_ANY_E_NOK; + goto exit; + } + hdev->pipes[delete_info->pipe].gate = NFC_HCI_INVALID_GATE; hdev->pipes[delete_info->pipe].dest_host = NFC_HCI_INVALID_HOST; break; -- 2.7.4
Powered by blists - more mailing lists