linux-kernel - Re: [PATCH v16 0/5] ZII RAVE platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOFm3uHLT5R6SLYpRApFOOh4_=qrhc234EKfk1n-_3AGzgN9RA@mail.gmail.com>
Date:   Wed, 20 Dec 2017 22:51:12 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Pavel Machek <pavel@....cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        cphealy@...il.com, Andy Shevchenko <andy.shevchenko@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Johan Hovold <johan@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        Sebastian Reichel <sebastian.reichel@...labora.co.uk>
Subject: Re: [PATCH v16 0/5] ZII RAVE platform driver

Andrey,

On Wed, Dec 20, 2017 at 9:45 PM, Andrey Smirnov
<andrew.smirnov@...il.com> wrote:
> Everyone:
>
> This patch series is v16 of the driver for supervisory processor found
> on RAVE series of devices from ZII. Supervisory processor is a PIC
> microcontroller connected to various electrical subsystems on RAVE
> devices whose firmware implements protocol to command/qery them.
>
> NOTE:
>
>  * This driver dependends on crc_ccitt_false(), added by
>    2da9378d531f8cc6670c7497f20d936b706ab80b in 'linux-next', the patch
>    was pulled in by Andrew Morton and is currently avaiting users, so
>    this series might have to go in through Andrew's tree
>
> Changes since [v15]:
>
>     - Adopted SPDX tags for licensing information per Philippe's
>       request

Thank you for using the SPDX tags: you have my cheerful ack for the
SPDX tags for the whole patch set

There is one minor problem though: your comment style for the SPDX tag
lines. Check Thomas doc patches and Linus comments on this topic: you
should use // C++ style commnent in .c files and /* */ C-style
comments in .h files.

e.g. do not use this for a .c file:

> +++ b/drivers/watchdog/rave-sp-wdt.c
> @@ -0,0 +1,337 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */

But this instead:

> +++ b/drivers/watchdog/rave-sp-wdt.c
> @@ -0,0 +1,337 @@
> +// SPDX-License-Identifier: GPL-2.0+


Acked-by: Philippe Ombredanne <pombredanne@...B.com>

-- 
Cordially
Philippe