linux-kernel - Re: [PATCH v1 1/1] ASoC: rsnd: ssi: Fix issue in dma data address assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k1xgbnfz.wl%kuninori.morimoto.gx@renesas.com>
Date:   Thu, 21 Dec 2017 06:42:17 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     <jiada_wang@...tor.com>
Cc:     <lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] ASoC: rsnd: ssi: Fix issue in dma data address assignment


Hi Jiada

Thank you for your patch

> Same SSI device may be used in different dai links,
> by only having one dma struct in rsnd_ssi, after the first
> instance's dma config be initilized, the following instances
> can no longer configure dma, this causes issue, when their
> dma data address are different from the first instance.
> 
> This patch by introduces two dma struct in rdai, each SSI
> instance in a dai link is assigned with two dma struct,
> to store dma configuration for playback and capture.
> 
> Signed-off-by: Jiada Wang <jiada_wang@...tor.com>
> ---
(snip)
> @@ -876,7 +876,7 @@ static int rsnd_ssi_dma_probe(struct rsnd_mod *mod,
>  		return ret;
>  
>  	/* SSI probe might be called many times in MUX multi path */
> -	ret = rsnd_dma_attach(io, mod, &ssi->dma);
> +	ret = rsnd_dma_attach(io, mod, &rdai->dma[is_play]);
>  
>  	return ret;
>  }

Some cases, same SSI might be used on different dai links.
In my understanding, it happen if you uses MIXer.
But, are you using same SSI for both playback and capture ??

Best regards
---
Kuninori Morimoto