linux-kernel - Re: [PATCH v3] checkpatch: Fix checks for Kconfig help text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Dec 2017 16:38:58 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] checkpatch: Fix checks for Kconfig help text

On Sat, Nov 18, 2017 at 04:48:01PM +0800, Leo Yan wrote:
> If one patch has Kconfig section, the check script variable '$is_start'
> will be set by first 'config' line and the variable '$is_end' is to be
> set by the second 'config' line. But patches often has only one
> 'config' line so we have no chance to set '$is_end', as result below
> condition is invalid and it skips check for Kconfig description:
> 
> 	if ($is_start && $is_end && $length < $min_conf_desc_length) {
> 		......
> 	}
> 
> When script runs to this condition sentence it means the Kconfig
> section parsing has been completed, whatever '$is_end' is true
> or not. So removes '$is_end' from condition sentence.

Gentle ping.

> Signed-off-by: Leo Yan <leo.yan@...aro.org>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 95cda3e..6050323 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2796,7 +2796,7 @@ sub process {
>  				}
>  				$length++;
>  			}
> -			if ($is_start && $is_end && $length < $min_conf_desc_length) {
> +			if ($is_start && $length < $min_conf_desc_length) {
>  				WARN("CONFIG_DESCRIPTION",
>  				     "please write a paragraph that describes the config symbol fully\n" . $herecurr);
>  			}
> -- 
> 2.7.4
>