linux-kernel - Re: [PATCH] Do not hash userspace addresses in fault handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1712211127280.1741@nanos>
Date:   Thu, 21 Dec 2017 11:27:52 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Kees Cook <keescook@...omium.org>
cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, "Tobin C. Harding" <me@...in.cc>,
        x86@...nel.org
Subject: Re: [PATCH] Do not hash userspace addresses in fault handlers

On Tue, 19 Dec 2017, Kees Cook wrote:
> diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
> index febf6980e653..06fe3d51d385 100644
> --- a/arch/x86/mm/fault.c
> +++ b/arch/x86/mm/fault.c
> @@ -860,7 +860,7 @@ show_signal_msg(struct pt_regs *regs, unsigned long error_code,
>  	if (!printk_ratelimit())
>  		return;
>  
> -	printk("%s%s[%d]: segfault at %lx ip %p sp %p error %lx",
> +	printk("%s%s[%d]: segfault at %lx ip %px sp %px error %lx",
>  		task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG,
>  		tsk->comm, task_pid_nr(tsk), address,
>  		(void *)regs->ip, (void *)regs->sp, error_code);

For that part:

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>