linux-kernel - [PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a trb, in ISO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <637796ED17F7774FB27D6AAE3C6951584B38C043@dggeml508-mbx.china.huawei.com>
Date:   Thu, 21 Dec 2017 11:03:44 +0000
From:   Lipengcheng <lpc.li@...ilicon.com>
To:     "balbi@...nel.org" <balbi@...nel.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Lipengcheng <lpc.li@...ilicon.com>
Subject: [PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a
 trb, in ISO

Iso transmission, the current process is that all trb(HWO=1) is handled.
Then core generate DWC3_DEPEVT_XFERNOTREADY event, Software begin  refill
trb, this will produce 0 length package, the patch is to achieve the core
consumes a trb, and then the software fill a trb. Normally, there will never
be DWC3_DEPEVT_XFERNOTREADY event and 0-length packet.

Signed-off-by: l00229106 <lpc.li@...ilicon.com>
---
 drivers/usb/dwc3/gadget.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 981fd98..1e6c42e 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -2420,7 +2420,7 @@ static void dwc3_endpoint_transfer_complete(struct dwc3 *dwc,
    if (!dep->endpoint.desc)
        return;

-   if (!usb_endpoint_xfer_isoc(dep->endpoint.desc))
+   if (!usb_endpoint_xfer_isoc(dep->endpoint.desc) || (dep->flags & DWC3_EP_TRANSFER_STARTED))
        __dwc3_gadget_kick_transfer(dep);
 }

--
2.7.4