linux-kernel - Re: pinctrl-amd: What hardware does it apply to?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Dec 2017 14:12:56 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Andrew Cooks <andrew.cooks@...ngear.com>,
        linux-gpio@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Nehal Shah <Nehal-bakulchandra.Shah@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Ken Xue <Ken.Xue@....com>,
        Tobias Diedrich <ranma+kernel@...edrich.de>,
        Sudheesh Mavila <sudheesh.mavila@....com>,
        platypus-sw <platypus-sw@...ngear.com>,
        Timur Tabi <timur@...eaurora.org>
Subject: Re: pinctrl-amd: What hardware does it apply to?

On Thu, Dec 21, 2017 at 11:11:18AM +0100, Linus Walleij wrote:
> > In contrast, the pinctrl-amd driver only mentions the newer KERNCZ platform
> > name and uses ACPI for probing without disclosing any Family or Model numbers.
> >
> > pinctrl-amd applies to "AMD0030" and "AMDI0030"
> >
> > The ACPI HID matching makes it difficult to determine what family and model the
> > driver applies to, or rather, I have not been able to find such a mapping of HIDs
> > to family and model numbers. It's also impossible to guess an ACPI _HID
> > that may or may not exist for the Family 16h Model 30h platform and even if I
> > allocate a new HID for our ACPI implementation, that HID has little hope of
> > being accepted into the mainline driver.
> 
> I didn't understand anything of what you just wrote.
> I am basically ignorant when it comes to ACPI details.
> 
> So let's CC the GPIO ACPI maintainer, Mika Westerberg.

If the hardware is not the same that is already supported by the
pinctrl-amd, then you definitely should allocate a new separate ACPI
_HID for it. That's pretty much what we do with every new SoC because
they typically don't have identical pin lists among other things.