linux-kernel - Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1513863613.2785.6.camel@intel.com>
Date:   Thu, 21 Dec 2017 21:40:13 +0800
From:   Zhang Rui <rui.zhang@...el.com>
To:     Matthias Brugger <matthias.bgg@...il.com>, edubezval@...il.com
Cc:     linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines

On Thu, 2017-12-21 at 11:01 +0100, Matthias Brugger wrote:
> 
> On 12/01/2017 11:43 AM, Matthias Brugger wrote:
> > 
> > The mtk_thermal has some defiens which are never used within the
> > driver.
> > This patch delets them.
> > 
> > Signed-off-by: Matthias Brugger <mbrugger@...e.com>
> > ---
> Rui, Eduardo, do you have any comments on this patch?
> 
No, I don't have any.
I suppose Eduardo will review them soon as I need the thermal soc
material for next merge window.

thanks,
rui
> Regards,
> Matthias
> 
> > 
> >  drivers/thermal/mtk_thermal.c | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> > 
> > diff --git a/drivers/thermal/mtk_thermal.c
> > b/drivers/thermal/mtk_thermal.c
> > index 1e61c09153c9..c75661a3801a 100644
> > --- a/drivers/thermal/mtk_thermal.c
> > +++ b/drivers/thermal/mtk_thermal.c
> > @@ -32,15 +32,10 @@
> >  #include <linux/types.h>
> >  
> >  /* AUXADC Registers */
> > -#define AUXADC_CON0_V		0x000
> > -#define AUXADC_CON1_V		0x004
> >  #define AUXADC_CON1_SET_V	0x008
> >  #define AUXADC_CON1_CLR_V	0x00c
> >  #define AUXADC_CON2_V		0x010
> >  #define AUXADC_DATA(channel)	(0x14 + (channel) * 4)
> > -#define AUXADC_MISC_V		0x094
> > -
> > -#define AUXADC_CON1_CHANNEL(x)	BIT(x)
> >  
> >  #define APMIXED_SYS_TS_CON1	0x604
> >  
> > @@ -158,8 +153,6 @@
> >  /* The number of sensing points per bank */
> >  #define MT2712_NUM_SENSORS_PER_ZONE	4
> >  
> > -#define THERMAL_NAME    "mtk-thermal"
> > -
> >  struct mtk_thermal;
> >  
> >  struct thermal_bank_cfg {
> > @@ -765,7 +758,7 @@ static struct platform_driver
> > mtk_thermal_driver = {
> >  	.probe = mtk_thermal_probe,
> >  	.remove = mtk_thermal_remove,
> >  	.driver = {
> > -		.name = THERMAL_NAME,
> > +		.name = "mtk-thermal",
> >  		.of_match_table = mtk_thermal_of_match,
> >  	},
> >  };
> >