linux-kernel - Re: [PATCH] ARM: dts: imx: Add memory node unit name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Dec 2017 12:26:38 -0200
From:   Marco Franchi <marcofrk@...il.com>
To:     Lothar Waßmann <LW@...o-electronics.de>
Cc:     Shawn Guo <shawnguo@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        Fabio Estevam <festevam@...il.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: imx: Add memory node unit name

Hi Lothar,

2017-12-21 6:07 GMT-02:00 Lothar Waßmann <LW@...o-electronics.de>:
> Hi,
>
> On Wed,  6 Dec 2017 13:59:49 -0200 Marco Franchi wrote:
>> Fix the following warnings from dtc by adding the unit name to memory
>> nodes:
>>
>> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>>
>> Converted using the following command:
>>
>> perl -p0777i -e 's/memory \{\n\t\treg = \<0x+([0-9a-f])/memory\@$1$\0000000 \{\n\t\treg = <0x$1/m' `find ./arch/arm/boot/dts -name "imx*"`
>>
>> The files below were manually fixed:
>> -imx1-ads.dts
>> -imx1-apf9328.dts
>>
> The imx*.dtsi files all have this:
> |       memory { device_type = "memory"; reg = <0 0>; };
> Thus you will end up with a 'memory' node with a reg = <0 0> entry and
> an additional 'memory@...' node with the correct 'reg' values.

You are right. The .dtb files were composed by two different memory nodes.
Do you have some recommendation to take off this specific warning?

>
>
> Lothar Waßmann

Marco Franchi