lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Dec 2017 16:08:40 +0100 From: Michal Hocko <mhocko@...nel.org> To: Pavel Machek <pavel@....cz> Cc: Michael Ellerman <mpe@...erman.id.au>, vojtech@...e.cz, jikos@...e.cz, Kees Cook <keescook@...omium.org>, "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, Cyril Hrubis <chrubis@...e.cz>, Linux API <linux-api@...r.kernel.org>, Khalid Aziz <khalid.aziz@...cle.com>, Russell King - ARM Linux <linux@...linux.org.uk>, Andrea Arcangeli <aarcange@...hat.com>, Linux-MM <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>, linux-arch <linux-arch@...r.kernel.org>, Florian Weimer <fweimer@...hat.com>, John Hubbard <jhubbard@...dia.com>, Matthew Wilcox <willy@...radead.org>, Jann Horn <jannh@...gle.com>, Mike Rapoport <rppt@...ux.vnet.ibm.com> Subject: Re: known bad patch in -mm tree was Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation On Thu 21-12-17 15:59:07, Pavel Machek wrote: > Hi! > > > >>> And if Michal doesn't want to touch this patch any more, I'm happy to > > >>> do the search/replace/resend. :P > > >> > > >> Something with the prefix MAP_FIXED_ seems to me obviously desirable, > > >> both to suggest that the function is similar, and also for easy > > >> grepping of the source code to look for instances of both. > > >> MAP_FIXED_SAFE didn't really bother me as a name, but > > >> MAP_FIXED_NOREPLACE (or MAP_FIXED_NOCLOBBER) seem slightly more > > >> descriptive of what the flag actually does, so a little better. > > > > > > Great, thanks! > > > > > > Andrew, can you s/MAP_FIXED_SAFE/MAP_FIXED_NOREPLACE/g in the series? > > > > This seems to have not happened. Presumably Andrew just missed the mail > > in the flood. And will probably miss this one too ... :) > > Nice way to mess up kernel development, Michal. Thank you! :-(. Thank you for your valuable feedback! Maybe you have noticed that I haven't enforced the patch and led others to decide the final name (either by resubmitting patches or a simple replace in mmotm tree). Or maybe you haven't because you are so busy bikesheding that you can hardly see anything else. > Andrew, everyone and their dog agrees MAP_FIXED_SAFE is stupid name, > but Michal decided to just go ahead, ignoring feedback... > > Can you either s/MAP_FIXED_SAFE/MAP_FIXED_NOREPLACE/g or drop the patches? You have surely saved the world today and I hardly find words to thank you (and your dog of course). Thanks! -- Michal Hocko SUSE Labs
Powered by blists - more mailing lists