linux-kernel - Re: [PATCH 1/9] dt-bindings: ti-sysc: Update binding for timers and capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171221152942.GT3875@atomide.com>
Date:   Thu, 21 Dec 2017 07:29:42 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-omap@...r.kernel.org, Nishanth Menon <nm@...com>,
        devicetree@...r.kernel.org, Paul Walmsley <paul@...an.com>,
        Dave Gerlach <d-gerlach@...com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Matthijs van Duin <matthijsvanduin@...il.com>,
        linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        Tero Kristo <t-kristo@...com>, Mark Brown <broonie@...nel.org>,
        Sakari Ailus <sakari.ailus@....fi>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Benoît Cousson <bcousson@...libre.com>,
        Mark Rutland <mark.rutland@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/9] dt-bindings: ti-sysc: Update binding for timers and
 capabilities

* Rob Herring <robh@...nel.org> [171220 18:13]:
> On Sat, Dec 16, 2017 at 11:22:22AM -0800, Tony Lindgren wrote:
> > I was planning to have "ti,sysc-delay-us" only in the driver, but
> > the same IP needs it set on dm814x while not on omap4 for OTG
> > for example. I could add SoC specific quirks to the driver
> > for that one if you prefer that instead?
> 
> No, I don't have a preference.

OK

> > > Are the bits you've defined all of them or there's more?
> > 
> > That's it, with this binding I've allocated the data from dts
> > for the tests I've done. So that should allow us to replace the
> > static data to start with as seen with the following command:
> > 
> > $ git grep -A10 "struct omap_hwmod_class_sysconfig" \
> > 	arch/arm/*hwmod*data*.c
> > ...
> > 
> > So that's to configure a big pile of different module
> > configurations we currently have as can be seen with:
> > 
> > $ git grep "struct omap_hwmod_class_sysconfig" \
> > 	arch/arm/*hwmod*data*.c | wc -l
> > 194
> > 
> > I'm sure there's still few duplicates there though..
> 
> Okay, then I guess I'm okay with this.
> 
> Reviewed-by: Rob Herring <robh@...nel.org>

OK thanks for the review.

Regards,

Tony