linux-kernel - Re: [PATCH 1/8] staging: lustre: Enclose complex macros in parantheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Dec 2017 16:43:27 +0100
From:   Christoph Volkert <linux@...istoph-volkert.de>
To:     Fabian Huegel <fabian_huegel@....de>
Cc:     Oleg Drokin <oleg.drokin@...el.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Lai Siyao <lai.siyao@...el.com>,
        "John L . Hammond" <john.hammond@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, lustre-devel@...ts.lustre.org,
        linux-kernel@...r.kernel.org, linux-kernel@...cs.fau.de
Subject: Re: [PATCH 1/8] staging: lustre: Enclose complex macros in
 parantheses

This is a duplicate patch. We fixed a typo and this was still left as a
temporary file. (emacs…) Sorry. The patch with Message-Id
<1513869932-27407-3-git-send-email-fabian_huegel@....de> is the right 
one.

We can provide a new patch series without the fix, if needed.

Thanks
Christoph

> Checkpatch wants complex macros to be enclosed in parantheses, so we
> put parantheses around these four macros.
> 
> Signed-off-by: Fabian Huegel <fabian_huegel@....de>
> Signed-off-by: Christoph Volkert <linux@...istoph-volkert.de>
> ---
>  drivers/staging/lustre/lustre/include/obd_class.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/obd_class.h
> b/drivers/staging/lustre/lustre/include/obd_class.h
> index 67c535c..5c8cf30 100644
> --- a/drivers/staging/lustre/lustre/include/obd_class.h
> +++ b/drivers/staging/lustre/lustre/include/obd_class.h
> @@ -294,10 +294,10 @@ struct obdo;
> 
>  void obdo_to_ioobj(const struct obdo *oa, struct obd_ioobj *ioobj);
> 
> -#define OBT(dev)	(dev)->obd_type
> -#define OBP(dev, op)    (dev)->obd_type->typ_dt_ops->op
> -#define MDP(dev, op)    (dev)->obd_type->typ_md_ops->op
> -#define CTXTP(ctxt, op) (ctxt)->loc_logops->lop_##op
> +#define OBT(dev)	((dev)->obd_type)
> +#define OBP(dev, op)    ((dev)->obd_type->typ_dt_ops->op)
> +#define MDP(dev, op)    ((dev)->obd_type->typ_md_ops->op)
> +#define CTXTP(ctxt, op) ((ctxt)->loc_logops->lop_##op)
> 
>  /* Ensure obd_setup: used for cleanup which must be called
>   * while obd is stopping