lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Dec 2017 16:34:16 +0000 From: "Shaikh, Azhar" <azhar.shaikh@...el.com> To: Javier Martinez Canillas <javierm@...hat.com>, Jason Gunthorpe <jgg@...pe.ca> CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, James Ettle <james@...le.org.uk>, Hans de Goede <hdegoede@...hat.com>, Arnd Bergmann <arnd@...db.de>, Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>, "Peter Huewe" <peterhuewe@....de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org> Subject: RE: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O memory region >-----Original Message----- >From: Javier Martinez Canillas [mailto:javierm@...hat.com] >Sent: Thursday, December 21, 2017 7:54 AM >To: Shaikh, Azhar <azhar.shaikh@...el.com>; Jason Gunthorpe ><jgg@...pe.ca> >Cc: linux-kernel@...r.kernel.org; James Ettle <james@...le.org.uk>; Hans de >Goede <hdegoede@...hat.com>; Arnd Bergmann <arnd@...db.de>; Jarkko >Sakkinen <jarkko.sakkinen@...ux.intel.com>; Peter Huewe ><peterhuewe@....de>; Greg Kroah-Hartman ><gregkh@...uxfoundation.org>; linux-integrity@...r.kernel.org >Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O >memory region > >On 12/21/2017 04:39 PM, Shaikh, Azhar wrote: >> HI Javier, >> >> >>> -----Original Message----- >>> From: linux-integrity-owner@...r.kernel.org [mailto:linux-integrity- >>> owner@...r.kernel.org] On Behalf Of Javier Martinez Canillas >>> Sent: Thursday, December 21, 2017 4:49 AM >>> To: Shaikh, Azhar <azhar.shaikh@...el.com>; Jason Gunthorpe >>> <jgg@...pe.ca> >>> Cc: linux-kernel@...r.kernel.org; James Ettle <james@...le.org.uk>; >>> Hans de Goede <hdegoede@...hat.com>; Arnd Bergmann ><arnd@...db.de>; >>> Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>; Peter Huewe >>> <peterhuewe@....de>; Greg Kroah-Hartman ><gregkh@...uxfoundation.org>; >>> linux-integrity@...r.kernel.org >>> Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already >>> unmapped I/O memory region >>> >>> Hello Azhar, >>> >>> On 12/20/2017 08:15 PM, Shaikh, Azhar wrote: >>>> >>>> >>>>> -----Original Message----- >>>>> From: Jason Gunthorpe [mailto:jgg@...pe.ca] >>>>> Sent: Wednesday, December 20, 2017 10:55 AM >>>>> To: Javier Martinez Canillas <javierm@...hat.com> >>>>> Cc: linux-kernel@...r.kernel.org; James Ettle <james@...le.org.uk>; >>>>> Hans de Goede <hdegoede@...hat.com>; Shaikh, Azhar >>>>> <azhar.shaikh@...el.com>; Arnd Bergmann <arnd@...db.de>; Jarkko >>>>> Sakkinen <jarkko.sakkinen@...ux.intel.com>; Peter Huewe >>>>> <peterhuewe@....de>; Greg Kroah-Hartman >>> <gregkh@...uxfoundation.org>; >>>>> linux- integrity@...r.kernel.org >>>>> Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already >>>>> unmapped I/O memory region >>>>> >>>>> On Wed, Dec 20, 2017 at 07:21:31PM +0100, Javier Martinez Canillas >wrote: >>>>> >>>>>>> The below draft fixes everything except #1. That needs a more >>>>>>> thoughtful idea.. >>>>>>> >>>>>> >>>>>> I'll just drop this patch from the series and you can fix all the >>>>>> issues in the error / driver removal paths. It's not a dependency >>>>>> anyways, I included it just because noticed the issue while >>>>>> reading the >>> code. >>>>> >>>>> Azhar, this means it becomes your problem :) >>>>> >>>> >>>> Sure, I will fix this. >>>> Javier you can drop this patch. >>>> >>> >>> On a second though, we should just merge $SUBJECT since is an obvious >>> fix for one of the issues. Then you could fix the remaining bugs in >>> error and driver removal paths. >> >> I think you are asking to keep this patch as a part of this series, itself and not >upload separately. Is this correct? Please correct me if I am wrong. >> > >Yes, what I meant is that we should just keep this patch in the series since it >fixes one of the resource cleanup bugs. Then you can fix the other issues as a >follow-up. > Ok, but even the patch which I will be submitting will be doing the cleanup. So it will just split the change. >Best regards, >-- >Javier Martinez Canillas >Software Engineer - Desktop Hardware Enablement Red Hat Regards, Azhar Shaikh
Powered by blists - more mailing lists