linux-kernel - Re: [PATCH 0/2] fs: fat: add ioctl to modify fat filesystem partion volume label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87fu83lw7z.fsf@mail.parknet.co.jp>
Date:   Fri, 22 Dec 2017 04:25:20 +0900
From:   OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:     Chen Guanqiao <chen.chenchacha@...mail.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] fs: fat: add ioctl to modify fat filesystem partion volume label

Chen Guanqiao <chen.chenchacha@...mail.com> writes:

> The FAT filesystem partition volume label can be read with
> FAT_IOCTL_GET_VOLUME_LABEL and written with FAT_IOCTL_SET_VOLUME_LABEL.
>
> v2:
> 1. add filesystem version check.
> 2. add diretory permissions check.
> 3. add volume label string check.
> 4. fixed part of return value.
> 5. fixed some indent issue.
> 6. remove sync_dirty_buffer().

As I said in previous email, those vol_label should be matching with
volume label in root directory, right? So I think handling only boot
sector's vol_label would not work as expected.

Does this really works as expected?

E.g. suspected test case is,

1) write label on windows
2) modify label on linux
3) read modified label on windows

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>