linux-kernel - Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Dec 2017 21:46:18 +0100
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Brian Norris <briannorris@...omium.org>,
        "Ghorai, Sukumar" <sukumar.ghorai@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "Bag, Amit K" <amit.k.bag@...el.com>,
        Oliver Neukum <oneukum@...e.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Todd Broch <tbroch@...omium.org>,
        Rajat Jain <rajatja@...omium.org>,
        Miao Chou <mcchou@...omium.org>,
        "Rao Pv, Sadashiva" <sadashiva.rao.pv@...el.com>
Subject: Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the
 usb-wakeup feature

On Thu, Dec 21, 2017 at 12:04:57PM -0800, Guenter Roeck wrote:
> On Thu, Dec 21, 2017 at 11:10:58AM -0800, Brian Norris wrote:
> > On Thu, Dec 21, 2017 at 07:05:03PM +0000, Ghorai, Sukumar wrote:
> > > >>On Thu, Dec 21, 2017 at 06:52:31PM +0000, Ghorai, Sukumar wrote:
> > > >> Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O
> > > >> device connected.
> > > >
> > > >Could you ever? If not, that looks like a feature request to me...
> > > Agree, feature request... however  we need this feature for rapid use of Bluetooth LE devices.
> > 
> > Is that what -stable is for now? For getting your pet feature enabled
> 
> I sincerely hope not. If -stable now officially supports adding new
> features, we'll have to revisit our strategy for merging stable releases.

I'm not trying to add any new features at all, this was added because I
was told it resolved an issue that people had with their hardware.

If that's not the case, and it causes more problems than it is worth,
then it needs to be dropped both from Linus's tree, and then from the
stable trees.

And what I mean by "bug compatible" is, if the bug is in Linus's tree
because of a commit that needs to be reverted, revert it there, and I
will also do the same thing in the stable tree.  No one wants to upgrade
from an older kernel to a newer one and hit a regression, so ideally it
gets fixed everywhere at the same time.

Now, it seems the bluetooth maintainers have disappeared lately, with no
patches being applied anymore, so I have no idea what is going on there
anymore, so I'll drop this from the stable tree and _hope_ someone gets
their act together and reverts it from Linus's tree too.

Guenter and Brian, is that ok?

thanks,

greg k-h