linux-kernel - BUG: EFI capsule loader fails as of 4.13, the capsule is not passed in contiguous virtual memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ee80aa6b-ceac-f410-0718-c998f9c66181@codeaurora.org>
Date:   Thu, 21 Dec 2017 14:42:43 -0700
From:   Richard Ruigrok <rruigrok@...eaurora.org>
To:     ge.song@...-semitech.com, ard.biesheuvel@...aro.org,
        matt@...eblueprint.co.uk
Cc:     linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org
Subject: BUG: EFI capsule loader fails as of 4.13, the capsule is not passed
 in contiguous virtual memory

The capsule pointer passed to efi services are expected to be in contiguous virtual memory, as per the EFI 2.6 Spec section 7.5.3, excerpt below.

This issue was previously reported and fixed in 4.9 stable: 6862e6ad95e9  efi/capsule: Allocate whole capsule into virtual memory

The series "First batch of EFI updates for v4.13" includes changes that break the efi loader as it is now passing only the first physical page of the EFI capsule.  As a result efi capsule updates are failing on Centriq products.

The series by Ge Song "Make capsules in a contiguous virtual space" was verified to work. 

Ref to the spec:

"CapsuleHeaderArrayVirtual pointer to an array of virtual pointers to the capsules being passed into update capsule. Each capsules is assumed to stored in contiguous virtual memory."

-- 
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.