linux-kernel - Re: ptrace versus setuid changes in 4.14?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jL_DdWCTnc_0zM=WZ0HNHaDfjpp48CTXVyy4_hAuW6_Mw@mail.gmail.com>
Date:   Fri, 22 Dec 2017 15:14:25 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Tom Horsley <horsley1953@...il.com>
Cc:     Laura Abbott <labbott@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        David Howells <dhowells@...hat.com>,
        Serge Hallyn <serge@...lyn.com>,
        James Morris <james.l.morris@...cle.com>
Subject: Re: ptrace versus setuid changes in 4.14?

On Fri, Dec 22, 2017 at 12:55 PM, Tom Horsley <horsley1953@...il.com> wrote:
> On Fri, 22 Dec 2017 12:28:25 -0800
> Laura Abbott wrote:
>
>> Assuming this is https://bugzilla.redhat.com/show_bug.cgi?id=1528633
>> This is yet another victim of
>>
>> commit e37fdb785a5f95ecadf43b773c97f676500ac7b8 (refs/bisect/bad)
>> Author: Kees Cook <keescook@...omium.org>
>> Date:   Tue Jul 18 15:25:31 2017 -0700
>>
>>      exec: Use secureexec for setting dumpability
>
> You mean there is hope this really is a bug and not a security
> enhancement? Amazing :-).
>
> And yes, that is the bugzilla I submitted after I reduced
> things to a small test program.

I think the secureexec dumpability logic just needs to be removed --
the logic in commit_creds() _should_ be sufficient, but I want to
double-check it now that I've got some more tests cases.

-Kees

-- 
Kees Cook
Pixel Security