linux-kernel - Re: usb: gadget: function: f_rndis:use dev_kfree_skb_irq instead of dev_kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 22 Dec 2017 09:56:03 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "lpc.li" <lpc.li@...wei.com>
Cc:     balbi@...nel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, lidongpo@...ilicon.com
Subject: Re: usb: gadget: function: f_rndis:use dev_kfree_skb_irq instead of
 dev_kfree_skb

On Fri, Dec 22, 2017 at 04:44:48PM +0800, lpc.li wrote:
> We can't use kfree_skb in irq disable context, because spin_lock_irqsave
> make sure we are always in irq disable context, use dev_kfree_skb_irq
> instead of kfree_skb is better than dev_kfree_skb_any.

Ok, but your patch uses:

>  -   dev_kfree_skb(skb);
>  +   dev_kfree_skb_any(skb);

the _any call, not _irq, did you test this?

thanks,

greg k-h