linux-kernel - Re: [PATCH 4.9 037/104] i2c: mux: pca954x: Add missing pca9546 definition to chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79870677-adc6-a5ff-99bc-e8aca3d28bfd@axentia.se>
Date:   Fri, 22 Dec 2017 10:32:14 +0100
From:   Peter Rosin <peda@...ntia.se>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org, Mike Looijmans <mike.looijmans@...ic.nl>,
        Sasha Levin <alexander.levin@...izon.com>
Subject: Re: [PATCH 4.9 037/104] i2c: mux: pca954x: Add missing pca9546
 definition to chip_desc

On 2017-12-22 09:46, Greg Kroah-Hartman wrote:
> 4.9-stable review patch.  If anyone has any objections, please let me know.

I don't think this is relevant since the interrupt support code was
added in 4.11 or something like that with
f2114795f721 ("i2c: mux: pca954x: Add interrupt controller support")

Before that pca9545 and pca9546 was handled the same so this patch
changes nothing. No harm though, so do whatever is simpler.

Naturally, the same applies for all older stable tree as well...

Cheers,
Peter

> 
> ------------------
> 
> From: Mike Looijmans <mike.looijmans@...ic.nl>
> 
> 
> [ Upstream commit dbe4d69d252e9e65c6c46826980b77b11a142065 ]
> 
> The spec for the pca9546 was missing. This chip is the same as the pca9545
> except that it lacks interrupt lines. While the i2c_device_id table mapped
> the pca9546 to the pca9545 definition the compatible table did not.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
> Signed-off-by: Peter Rosin <peda@...ntia.se>
> Signed-off-by: Sasha Levin <alexander.levin@...izon.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/i2c/muxes/i2c-mux-pca954x.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> --- a/drivers/i2c/muxes/i2c-mux-pca954x.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
> @@ -96,6 +96,10 @@ static const struct chip_desc chips[] =
>  		.nchans = 4,
>  		.muxtype = pca954x_isswi,
>  	},
> +	[pca_9546] = {
> +		.nchans = 4,
> +		.muxtype = pca954x_isswi,
> +	},
>  	[pca_9547] = {
>  		.nchans = 8,
>  		.enable = 0x8,
> @@ -113,7 +117,7 @@ static const struct i2c_device_id pca954
>  	{ "pca9543", pca_9543 },
>  	{ "pca9544", pca_9544 },
>  	{ "pca9545", pca_9545 },
> -	{ "pca9546", pca_9545 },
> +	{ "pca9546", pca_9546 },
>  	{ "pca9547", pca_9547 },
>  	{ "pca9548", pca_9548 },
>  	{ }
> 
>