linux-kernel - [PATCH] staging: most: Fix identifiers to function parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 22 Dec 2017 15:39:02 +0530
From:   venkataravi.e@...hveda.org
To:     gregkh@...uxfoundation.org
Cc:     christian.gromm@...rochip.com, steve.knipe@...il.com,
        gustavo@...eddedor.com, andrey.shvetsov@....de,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        sunil.m@...hveda.org, shrikant.maurya@...hveda.org,
        Ravi Eluri <venkataravi.e@...hveda.org>
Subject: [PATCH] staging: most: Fix identifiers to function parameters

From: Ravi Eluri <venkataravi.e@...hveda.org>

fixed "function definition argument should have an identifier name",
with appropriate identifier names. Pointed out by checkpatch.

Signed-off-by: Ravi Eluri <venkataravi.e@...hveda.org>
Signed-off-by: Suniel Mahesh <sunil.m@...hveda.org>
---
Note:
- This is the first patch of the two patch series.
- Patch was compile tested and built(ARCH=arm) on linux-next
  (latest).
- No build/run-time issues reported.
---
 drivers/staging/most/dim2/dim2.c | 4 ++--
 drivers/staging/most/usb/usb.c   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
index 2bd40ab..21e3fb4 100644
--- a/drivers/staging/most/dim2/dim2.c
+++ b/drivers/staging/most/dim2/dim2.c
@@ -101,8 +101,8 @@ struct dim2_hdm {
 	unsigned char link_state;
 	int atx_idx;
 	struct medialb_bus bus;
-	void (*on_netinfo)(struct most_interface *,
-			   unsigned char, unsigned char *);
+	void (*on_netinfo)(struct most_interface *most_iface,
+			   unsigned char link_state, unsigned char *addrs);
 };
 
 #define iface_to_hdm(iface) container_of(iface, struct dim2_hdm, most_iface)
diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c
index 8d23075..31f184c 100644
--- a/drivers/staging/most/usb/usb.c
+++ b/drivers/staging/most/usb/usb.c
@@ -117,8 +117,8 @@ struct most_dev {
 	struct mutex io_mutex;
 	struct timer_list link_stat_timer;
 	struct work_struct poll_work_obj;
-	void (*on_netinfo)(struct most_interface *, unsigned char,
-			   unsigned char *);
+	void (*on_netinfo)(struct most_interface *most_iface,
+			   unsigned char link_state, unsigned char *addrs);
 };
 
 #define to_mdev(d) container_of(d, struct most_dev, iface)
-- 
1.9.1