linux-kernel - Re: [PATCH] nfsd: fix incorrect indentation on goto statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Dec 2017 09:11:38 +0800
From:   Kinglong Mee <kinglongmee@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     "J . Bruce Fields" <bfields@...ldses.org>,
        Jeff Layton <jlayton@...nel.org>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfsd: fix incorrect indentation on goto statement

On Fri, Dec 22, 2017 at 8:35 AM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The goto statement requires one more level of indentation, add it.

Those "break" in this switch need one more level too,
it's nice to add them in this patch.

thanks,
Kinglong Mee

>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  fs/nfsd/nfs4state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index b29b5a185a2c..3bb720a59b49 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -6159,7 +6159,7 @@ nfsd4_lockt(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
>                 default:
>                         dprintk("NFSD: nfs4_lockt: bad lock type!\n");
>                         status = nfserr_inval;
> -               goto out;
> +                       goto out;
>         }
>
>         lo = find_lockowner_str(cstate->clp, &lockt->lt_owner);
> --
> 2.14.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html