lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <95F51F4B902CAC40AF459205F6322F01B7FDFECC3F@BMK019S01.emtrion.local> Date: Fri, 22 Dec 2017 12:44:26 +0100 From: Türk, Jan <Jan.Tuerk@...rion.de> To: 'Alexandre Belloni' <alexandre.belloni@...e-electrons.com>, Andreas Färber <afaerber@...e.de>, Philippe Ombredanne <pombredanne@...b.com> CC: 'Rob Herring' <robh@...nel.org>, Mark Rutland <mark.rutland@....com>, Thierry Reding <thierry.reding@...il.com>, David Airlie <airlied@...ux.ie>, Russell King <linux@...linux.org.uk>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <kernel@...gutronix.de>, Fabio Estevam <fabio.estevam@....com>, Kevin Hilman <khilman@...libre.com>, Maxime Ripard <maxime.ripard@...e-electrons.com>, SZ Lin <sz.lin@...a.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, LinuxArmKernelMailingListe <linux-arm-kernel@...ts.infradead.org> Subject: AW: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series Hi, > On 22/12/2017 at 11:43:33 +0100, Andreas Färber wrote: > > >> I'll change it for v3 of this patch however it will end up like this: > > >> //SPDX-License... > > > > > > That should be /* SPDX-License */, // is for c files. > > > > Got any reference for that? Since we're using the C preprocessor > > before feeding them to dtc, we can use the same // style for both, builds fine. > > > > Only for my private DT overlay files that I use directly with dtc I > > couldn't adopt that style. > > > The doc states: > > If a specific tool cannot handle the standard comment style, then the > appropriate comment mechanism which the tool accepts shall be used. This is > the reason for having the "/\* \*/" style comment in C header files. > > I interpreted that as dtc doesn't handle // comments, use /**/ > > But I agree it also states: > .dts{i}: // SPDX-License-Identifier: <SPDX License Expression> > > So I think we will end up with a mix of both. > after some regexp on arch/arm/boot/dts, the current state is: 216 SPDX identifiers total 184 by GregKH in b24413180f5600bcb3bb70fbed5cf186b60864bd starting with // 2 times /* also by GregKH in the commit above (in .h files) 27 occurrences of "* SPDX" However, the de-facto comment style in the arm devicetrees seems to be /* */ So with the current information I would prepare v3 with: // SPDX-License-Identifier /* Copyright-text + Header */ [...] Jan --- emtrion GmbH Alter Schlachthof 45 76131 Karlsruhe GERMANY https://www.emtrion.de Amtsgericht Mannheim HRB 110 300 Geschäftsführer: Dieter Baur, Ramona Maurer
Powered by blists - more mailing lists