linux-kernel - Re: [PATCH] drm: fix tainted kernel caused by drm_panel_orientation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92cad55e-f225-2ae0-a091-a03b40c3a98d@gmail.com>
Date:   Fri, 22 Dec 2017 12:50:46 +0100
From:   Hans de Goede <j.w.r.degoede@...il.com>
To:     David Lechner <david@...hnology.com>,
        dri-devel@...ts.freedesktop.org
Cc:     Daniel Vetter <daniel.vetter@...el.com>,
        Gustavo Padovan <gustavo@...ovan.org>,
        Sean Paul <seanpaul@...omium.org>,
        David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: fix tainted kernel caused by
 drm_panel_orientation_quirks.c

Hi,

On 21-12-17 19:46, David Lechner wrote:
> drm_panel_orientation_quirks.c introduced in commit 404d1a3edc38 ("drm:
> Add panel orientation quirks, v6.") taints the kernel when compiled as a
> module. Fix this by adding MODULE_LICENSE().
> 
> Signed-off-by: David Lechner <david@...hnology.com>

Thank you for taking care of this, looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>   drivers/gpu/drm/drm_panel_orientation_quirks.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 901a4e9..1f2af70 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -9,6 +9,7 @@
>    */
>   
>   #include <linux/dmi.h>
> +#include <linux/module.h>
>   #include <drm/drm_connector.h>
>   
>   #ifdef CONFIG_DMI
> @@ -172,3 +173,5 @@ int drm_get_panel_orientation_quirk(int width, int height)
>   EXPORT_SYMBOL(drm_get_panel_orientation_quirk);
>   
>   #endif
> +
> +MODULE_LICENSE("Dual MIT/GPL");
>