linux-kernel - Re: [PATCH v2] virt: vbox: use %pap format for printing resource_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <121f58a5-c407-a604-982a-3aa61b6b006e@redhat.com>
Date:   Fri, 22 Dec 2017 13:03:46 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Joe Perches <joe@...ches.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] virt: vbox: use %pap format for printing
 resource_size_t

Hi,

On 21-12-17 17:15, Arnd Bergmann wrote:
> resource_size_t may be larger than pointers depending on configuration,
> so we can run into this build warning:
> 
> drivers/virt/vboxguest/vboxguest_linux.c: In function 'vbg_pci_probe':
> drivers/virt/vboxguest/vboxguest_linux.c:295:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> drivers/virt/vboxguest/vboxguest_linux.c:367:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> 
> This uses the special %pap to print the address by reference.
> 
> Fixes: 0ba002bc4393 ("virt: Add vboxguest driver for Virtual Box Guest integration")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> v2: Use %pap instead of the %rR that was just as incorrect, as
>      pointed out by Joe Perches.

Thank you for fixing this, the fix looks good to me:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans





> ---
>   drivers/virt/vboxguest/vboxguest_linux.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
> index d045aa51ce03..82e280d38cc2 100644
> --- a/drivers/virt/vboxguest/vboxguest_linux.c
> +++ b/drivers/virt/vboxguest/vboxguest_linux.c
> @@ -291,8 +291,8 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
>   
>   	vmmdev = devm_ioremap(dev, mmio, mmio_len);
>   	if (!vmmdev) {
> -		vbg_err("vboxguest: Error ioremap failed; MMIO addr=%p size=%d\n",
> -			(void *)mmio, (int)mmio_len);
> +		vbg_err("vboxguest: Error ioremap failed; MMIO addr=%pap size=%pap\n",
> +			&mmio, &mmio_len);
>   		goto err_disable_pcidev;
>   	}
>   
> @@ -362,9 +362,9 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
>   	device_create_file(dev, &dev_attr_host_version);
>   	device_create_file(dev, &dev_attr_host_features);
>   
> -	vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %p (size %d)\n",
> +	vbg_info("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pap (size %pap)\n",
>   		 gdev->misc_device.minor, pci->irq, gdev->io_port,
> -		 (void *)mmio, (int)mmio_len);
> +		 &mmio, &mmio_len);
>   
>   	return 0;
>   
>