linux-kernel - Re: [PATCHv3] printk: add console_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171222143024.awvhdl2jhwj7hwes@pathway.suse.cz>
Date:   Fri, 22 Dec 2017 15:30:24 +0100
From:   Petr Mladek <pmladek@...e.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Fengguang Wu <fengguang.wu@...el.com>,
        Kevin Hilman <khilman@...libre.com>,
        Mark Brown <broonie@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCHv3] printk: add console_msg_format command line option

On Thu 2017-12-21 14:41:49, Sergey Senozhatsky wrote:
> This patch introduces a `console_msg_format=' command line option,
> to switch between different message formatting on serial consoles.
> For the time being we have just two options - default and syslog.
> The "default" option just keeps the existing format. While the
> "syslog" option makes serial console messages to appear in syslog
> format [syslog() syscall], matching the `dmesg -S --raw' and
> `cat /proc/kmsg' output formats:
> 
> - facility and log level
> - time stamp (depends on printk_time/PRINTK_TIME)
> - message
> 
> 	<%u>[time stamp] text\n
> 

> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Reviewed-by: Fengguang Wu <fengguang.wu@...el.com>
> Reviewed-by: Kevin Hilman <khilman@...libre.com>
> Tested-by: Kevin Hilman <khilman@...libre.com>

The patch looks and works good for me.

Reviewed-by: Petr Mladek <pmladek@...e.com>

I am going to add it into for-4.16 branch when I am back in January.
The patch is basically innocent. But I do not want to eventually
screw up printk.git with a last minute commit.

Best Regards,
Petr