linux-kernel - Re: [PATCH 1/5] bindings: regulator: added support for suspend states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171222154904.GK1827@finisterre>
Date:   Fri, 22 Dec 2017 15:49:04 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Chunyan Zhang <zhang.chunyan@...aro.org>
Cc:     Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Chunyan Zhang <zhang.lyra@...il.com>
Subject: Re: [PATCH 1/5] bindings: regulator: added support for suspend states

On Fri, Dec 22, 2017 at 02:05:21PM +0800, Chunyan Zhang wrote:
> On 22 December 2017 at 07:26, Rob Herring <robh@...nel.org> wrote:
> > On Thu, Dec 21, 2017 at 02:25:02PM +0800, Chunyan Zhang wrote:

> >> +     - regulator-suspend-microvolt: the default voltage which regulator
> >> +       should be set in suspend, this can be adjusted among
> >> +       <regulator-suspend-min-microvolt, regulator-suspend-max-microvolt>

> > Perhaps this should stay a single property with: <target> <min> <max>

> Do you mean that change the property name from "regulator-suspend-microvolt" to
> "regulator-suspend-target-microvolt"?

> "regulator-suspend-microvolt" is the one that some SoC is using. My
> intention was just to keep that configuration still working.

Yeah, the regulator-suspend-microvolt is an existing property.  Thinking
about it we should probably say that it's equivalent to setting both
-min and -max to the same value and possibly mark it as deprecated too.
It is documented in regulator.txt already.

> > Though why would you ever not try to set to the minimum voltage within
> > the range of <min> to <max>?

> IIUC, you mean just removing "regulator-suspend-microvolt", and use
> "regulator-suspend-min-microvolt" as the default value for suspend
> voltage?
> I think that can work, but would it be better to not remove that right
> now, since some one is using that?

Indeed.  I think my suggestion above would cover things.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)