linux-kernel - Re: Bug in patch "x86/pti: Add the pti= cmdline option and documentation"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171222164334.eyiyudqqj5wpenrr@pd.tnic>
Date:   Fri, 22 Dec 2017 17:43:34 +0100
From:   Borislav Petkov <bp@...e.de>
To:     Juergen Gross <jgross@...e.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: Bug in patch "x86/pti: Add the pti= cmdline option and
 documentation"

On Fri, Dec 22, 2017 at 05:41:32PM +0100, Juergen Gross wrote:
> The patch in the tip tree with commit 506bcdf68b07a0335751e1fe8be37
> ("x86/pti: Add the pti= cmdline option and documentation") is completely
> wrong: cmdline_find_option() will return -1 in case the otion isn't
> found and the len of the argument in case it has been found.

It is not completely wrong - we still walk into the if-branch. Besides,
we moved the xen check upwards, before that so it is not relevant for
the xen case.

Regardless, I'll send a correction soon to check the retval directly.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--