linux-kernel - Re: [PATCH 07/45] drivers: infiniband: remove duplicate includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171222164522.GA20267@ziepe.ca>
Date:   Fri, 22 Dec 2017 09:45:22 -0700
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Pravin Shedge <pravin.shedge4linux@...il.com>
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        leonro@...lanox.com, saeedm@...lanox.com
Subject: Re: [PATCH 07/45] drivers: infiniband: remove duplicate includes

On Wed, Dec 06, 2017 at 10:19:39PM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
> 
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@...il.com>
>  drivers/infiniband/core/mad.c                | 1 -
>  drivers/infiniband/core/netlink.c            | 2 --
>  drivers/infiniband/hw/mlx5/main.c            | 4 +---
>  drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 1 -
>  drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 1 -
>  5 files changed, 1 insertion(+), 8 deletions(-)

I applied this to for-next, thanks

> index 543d0a4..fe435ed 100644
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -50,16 +50,14 @@
>  #include <rdma/ib_cache.h>
>  #include <linux/mlx5/port.h>
>  #include <linux/mlx5/vport.h>
> +#include <linux/mlx5/fs.h>
>  #include <linux/list.h>
>  #include <rdma/ib_smi.h>
>  #include <rdma/ib_umem.h>
>  #include <linux/in.h>
>  #include <linux/etherdevice.h>
> -#include <linux/mlx5/fs.h>
> -#include <linux/mlx5/vport.h>
>  #include "mlx5_ib.h"
>  #include "cmd.h"
> -#include <linux/mlx5/vport.h>

Yep, ugh.

Jason