linux-kernel - Re: [PATCH 4.4 75/78] Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Dec 2017 09:32:52 -0800
From:   Brian Norris <briannorris@...omium.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Sukumar Ghorai <sukumar.ghorai@...el.com>,
        Amit K Bag <amit.k.bag@...el.com>,
        Oliver Neukum <oneukum@...e.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH 4.4 75/78] Revert "Bluetooth: btusb: driver to enable the
 usb-wakeup feature"

Hi,

On Fri, Dec 22, 2017 at 09:46:56AM +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> This reverts commit ffc7565746bb2fc063fc0f484c55ef6d8951a6ee which is
> commit a0085f2510e8976614ad8f766b209448b385492f upstream.
> 
> It causes problems with working systems, as noted by a number of the
> ChromeOS developers.
> 
> Cc: Sukumar Ghorai <sukumar.ghorai@...el.com>
> Cc: Amit K Bag <amit.k.bag@...el.com>
> Cc: Oliver Neukum <oneukum@...e.com>
> Cc: Marcel Holtmann <marcel@...tmann.org>
> Cc: Matthias Kaehlcke <mka@...omium.org>
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Reported-by: Brian Norris <briannorris@...omium.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

FWIW:
Acked-by: Brian Norris <briannorris@...omium.org>

Thanks for working past the confusion.

> ---
>  drivers/bluetooth/btusb.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -1050,10 +1050,6 @@ static int btusb_open(struct hci_dev *hd
>  		return err;
>  
>  	data->intf->needs_remote_wakeup = 1;
> -	/* device specific wakeup source enabled and required for USB
> -	 * remote wakeup while host is suspended
> -	 */
> -	device_wakeup_enable(&data->udev->dev);
>  
>  	if (test_and_set_bit(BTUSB_INTR_RUNNING, &data->flags))
>  		goto done;
> @@ -1117,7 +1113,6 @@ static int btusb_close(struct hci_dev *h
>  		goto failed;
>  
>  	data->intf->needs_remote_wakeup = 0;
> -	device_wakeup_disable(&data->udev->dev);
>  	usb_autopm_put_interface(data->intf);
>  
>  failed:
> 
>