linux-kernel - Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171222173747.GB127515@google.com>
Date:   Fri, 22 Dec 2017 09:37:48 -0800
From:   Brian Norris <briannorris@...omium.org>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Matthias Kaehlcke <mka@...omium.org>,
        "Ghorai, Sukumar" <sukumar.ghorai@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "Bag, Amit K" <amit.k.bag@...el.com>,
        Oliver Neukum <oneukum@...e.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Todd Broch <tbroch@...omium.org>,
        Rajat Jain <rajatja@...omium.org>,
        Miao Chou <mcchou@...omium.org>,
        "Rao Pv, Sadashiva" <sadashiva.rao.pv@...el.com>
Subject: Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the
 usb-wakeup feature

On Fri, Dec 22, 2017 at 08:48:28AM +0100, Greg Kroah-Hartman wrote:
> I've reverted this from 4.4 and 4.9-stable, but note that this was

Thanks!

> included in 4.14-rc1, so something needs to be done in Linus's tree to
> resolve this issue, otherwise people will hit this as a regression when
> moving to 4.14 or newer.

Well, I wouldn't object to reverting it in Linus' tree too, since AFAIK,
this is something that can be configured by user-space policy, no? And
that way, no user space is surprised by the sudden additional
requirements on managing bluetooth wakeup.

I'm not intimately familiar with bluetooth though; I just (think I) know
a regression when I see one, as well as the difference between a feature
addition and a bugfix. But I'm not sure I'm the authority on what to do
with this feature. Many who are CC'd should know better.

Brian