linux-kernel - [PATCH v2] lib: add module unload support to sort tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1513967133-6843-1-git-send-email-pravin.shedge4linux@gmail.com>
Date:   Fri, 22 Dec 2017 23:55:33 +0530
From:   Pravin Shedge <pravin.shedge4linux@...il.com>
To:     akpm@...ux-foundation.org, fkostenzer@...e.at,
        andriy.shevchenko@...ux.intel.com, geert@...ux-m68k.org,
        paul.gortmaker@...driver.com, linux-kernel@...r.kernel.org
Cc:     pravin.shedge4linux@...il.com
Subject: [PATCH v2] lib: add module unload support to sort tests

test_sort.c perform array-based and linked list sort test. Code allows to
compile either as a loadable modules or builtin into the kernel.

Current code is not allow to unload the test_sort.ko module after
successful completion.

This patch add support to unload the "test_sort.ko" module by
adding module_exit support.

Previous patch was implemented auto unload support by returning
-EAGAIN from module_init() function on successful case, but this
approach is not ideal.

The auto-unload might seem like a nice optimization, but it encourages
inconsistent behaviour.  And behaviour that is different from all other
normal modules.

Signed-off-by: Pravin Shedge <pravin.shedge4linux@...il.com>
---
 lib/test_sort.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/test_sort.c b/lib/test_sort.c
index d389c1c..385c0ed 100644
--- a/lib/test_sort.c
+++ b/lib/test_sort.c
@@ -39,5 +39,11 @@ static int __init test_sort_init(void)
 	return err;
 }

+static void __exit test_sort_exit(void)
+{
+}
+
 module_init(test_sort_init);
+module_exit(test_sort_exit);
+
 MODULE_LICENSE("GPL");
-- 
2.7.4