linux-kernel - Re: [PATCH v3 27/27] devres: kill devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171223134532.GA10103@kroah.com>
Date:   Sat, 23 Dec 2017 14:45:32 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yisheng Xie <xieyisheng1@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org,
        ulf.hansson@...aro.org, jakub.kicinski@...ronome.com,
        airlied@...ux.ie, linux-wireless@...r.kernel.org,
        linus.walleij@...aro.org, alsa-devel@...a-project.org,
        dri-devel@...ts.freedesktop.org,
        platform-driver-x86@...r.kernel.org, linux-ide@...r.kernel.org,
        linux-mtd@...ts.infradead.org, daniel.vetter@...el.com,
        dan.j.williams@...el.com, jason@...edaemon.net,
        linux-rtc@...r.kernel.org, boris.brezillon@...e-electrons.com,
        mchehab@...nel.org, dmaengine@...r.kernel.org,
        vinod.koul@...el.com, richard@....at, marek.vasut@...il.com,
        industrypack-devel@...ts.sourceforge.net,
        linux-pci@...r.kernel.org, dvhart@...radead.org,
        linux@...ck-us.net, linux-media@...r.kernel.org,
        seanpaul@...omium.org, devel@...verdev.osuosl.org,
        linux-watchdog@...r.kernel.org, arnd@...db.de,
        b.zolnierkie@...sung.com, marc.zyngier@....com, jslaby@...e.com,
        jani.nikula@...ux.intel.com, linux-can@...r.kernel.org,
        linux-gpio@...r.kernel.org, broonie@...nel.org, mkl@...gutronix.de,
        linux-fbdev@...r.kernel.org, nios2-dev@...ts.rocketboards.org,
        bhelgaas@...gle.com, tglx@...utronix.de,
        andriy.shevchenko@...ux.intel.com, kvalo@...eaurora.org,
        a.zummo@...ertech.it, netdev@...r.kernel.org,
        linux-mmc@...r.kernel.org, lgirdwood@...il.com,
        ralf@...ux-mips.org, linux-spi@...r.kernel.org, ysxie@...mail.com,
        wg@...ndegger.com, cyrille.pitchen@...ev4u.fr, tj@...nel.org,
        alexandre.belloni@...e-electrons.com, davem@...emloft.net,
        andy@...radead.org
Subject: Re: [PATCH v3 27/27] devres: kill devm_ioremap_nocache

On Sat, Dec 23, 2017 at 07:02:59PM +0800, Yisheng Xie wrote:
> --- a/lib/devres.c
> +++ b/lib/devres.c
> @@ -44,35 +44,6 @@ void __iomem *devm_ioremap(struct device *dev, resource_size_t offset,
>  EXPORT_SYMBOL(devm_ioremap);
>  
>  /**
> - * devm_ioremap_nocache - Managed ioremap_nocache()
> - * @dev: Generic device to remap IO address for
> - * @offset: Resource address to map
> - * @size: Size of map
> - *
> - * Managed ioremap_nocache().  Map is automatically unmapped on driver
> - * detach.
> - */
> -void __iomem *devm_ioremap_nocache(struct device *dev, resource_size_t offset,
> -				   resource_size_t size)
> -{
> -	void __iomem **ptr, *addr;
> -
> -	ptr = devres_alloc(devm_ioremap_release, sizeof(*ptr), GFP_KERNEL);
> -	if (!ptr)
> -		return NULL;
> -
> -	addr = ioremap_nocache(offset, size);

Wait, devm_ioremap() calls ioremap(), not ioremap_nocache(), are you
_SURE_ that these are all identical?  For all arches?  If so, then
ioremap_nocache() can also be removed, right?

In my quick glance, I don't think you can do this series at all :(

greg k-h