linux-kernel - Re: [PATCH] scripts: Add device_attr_<rw|ro|wr>.pl scripts to convert DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1514039067.4599.21.camel@perches.com>
Date:   Sat, 23 Dec 2017 06:24:27 -0800
From:   Joe Perches <joe@...ches.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] scripts: Add device_attr_<rw|ro|wr>.pl scripts to
 convert DEVICE_ATTR uses

On Sat, 2017-12-23 at 15:19 +0100, Greg Kroah-Hartman wrote:
> On Fri, Dec 22, 2017 at 12:02:47PM -0800, Joe Perches wrote:
> > There are many uses of the DEVICE_ATTR(var, perms, show, store)
> > declaration macro that could use one of the convenience macros
> > DEVICE_ATTR_RW, DEVICE_ATTR_RO, or DEVICE_ATTR_WO.
> > 
> > These scripts automate those conversions.
[]
> We should just fix up all in-kernel users, no need to put the scripts in
> the kernel source tree, right?

There's really no need for these scripts in the kernel-tree
just as there's no real need for any coccinelle script once
any conversion is fully done.

Keeping the scripts around can help find more opportunities
for conversion as new code is added.