[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e912dbdb-3614-cee0-c7f7-2b5f6344466f@huawei.com>
Date: Sat, 23 Dec 2017 11:14:07 +0800
From: Chao Yu <yuchao0@...wei.com>
To: Yunlong Song <yunlong.song@...wei.com>, <jaegeuk@...nel.org>,
<chao@...nel.org>, <yunlong.song@...oud.com>
CC: <miaoxie@...wei.com>, <bintian.wang@...wei.com>,
<shengyong1@...wei.com>, <heyunlei@...wei.com>,
<linux-fsdevel@...r.kernel.org>,
<linux-f2fs-devel@...ts.sourceforge.net>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] fsck.f2fs: check nid range before use to avoid
segmentation fault
On 2017/12/18 19:53, Yunlong Song wrote:
> Signed-off-by: Yunlong Song <yunlong.song@...wei.com>
How about introducing IS_AVAILABLE_NID as below, and use it instead?
#define IS_AVAILABLE_NID(sbi, nid) (IS_VALID_NID(sbi, nid) && (nid >= root_ino))
Thanks,
> ---
> fsck/fsck.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fsck/fsck.c b/fsck/fsck.c
> index 11b8b0b..faf0663 100644
> --- a/fsck/fsck.c
> +++ b/fsck/fsck.c
> @@ -740,7 +740,7 @@ void fsck_chk_inode_blk(struct f2fs_sb_info *sbi, u32 nid,
> for (idx = 0; idx < 5; idx++) {
> u32 nid = le32_to_cpu(node_blk->i.i_nid[idx]);
>
> - if (nid != 0) {
> + if (nid != 0 && IS_VALID_NID(sbi, nid)) {
> struct node_info ni;
>
> get_node_info(sbi, nid, &ni);
>
Powered by blists - more mailing lists