linux-kernel - Re: [PATCH v4] fsck.f2fs: check and fix i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc26fe9c-15fd-29cc-578a-ed5f7e906e88@huawei.com>
Date:   Sat, 23 Dec 2017 11:40:03 +0800
From:   Yunlong Song <yunlong.song@...wei.com>
To:     Chao Yu <yuchao0@...wei.com>, <jaegeuk@...nel.org>,
        <chao@...nel.org>, <yunlong.song@...oud.com>
CC:     <miaoxie@...wei.com>, <bintian.wang@...wei.com>,
        <shengyong1@...wei.com>, <heyunlei@...wei.com>,
        <linux-fsdevel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] fsck.f2fs: check and fix i_namelen to avoid double
 free

And there is en[namelen] = '\0', should fix namelen to its right value.

On 2017/12/23 11:35, Chao Yu wrote:
> On 2017/12/23 11:19, Yunlong Song wrote:
>> Double free problem:
>> Since ddr bit jump makes i_namelen a larger value (> 255)，when file is
>> not encrypted,
>> the convert_encrypted_name will memcpy out range of en[255], when en is
>> freed, there
>> will be double free problem.
> It looks there is only memcpy overflow problem here.
>
> Thanks,
>
>> On 2017/12/23 11:05, Chao Yu wrote:
>>> On 2017/12/18 21:25, Yunlong Song wrote:
>>>> v1 -> v2: use child_info to pass dentry namelen
>>>> v2 -> v3: check child != NULL to include the F2FS_FT_ORPHAN file type
>>>> v3 -> v4: fix the i_namelen problem of dump.f2fs、
>>> There is no commit log, so what do you mean about "avoid double free"?
>>>
>>> Other than that, looks good to me.
>>>
>>> Reviewed-by: Chao Yu <yuchao0@...wei.com>
>>>
>>> Thanks,
>>>
>>>
>>> .
>>>
>
> .
>

-- 
Thanks,
Yunlong Song