linux-kernel - [PATCH] xfs: destroy mutex qi_tree_lock before free xfs_quotainfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 24 Dec 2017 20:34:47 +0800
From:   Xiongwei Song <sxwjean@...il.com>
To:     darrick.wong@...cle.com, linux-xfs@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: [PATCH] xfs: destroy mutex qi_tree_lock before free xfs_quotainfo_t object

The mutex qi_tree_lock of xfs_quotainfo_t object was initialized when
calling xfs_qm_init_quotainfo, but it was not destroyed before free
xfs_quotainfo_t object when calling xfs_qm_destroy_quotainfo, this was
incorrect, so destroy it in function xfs_qm_destroy_quotainfo.

Signed-off-by: Xiongwei Song <sxwjean@...il.com>
---
 fs/xfs/xfs_qm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
index ec952dfad359..deceef5cbbf3 100644
--- a/fs/xfs/xfs_qm.c
+++ b/fs/xfs/xfs_qm.c
@@ -737,6 +737,7 @@ xfs_qm_destroy_quotainfo(
 		qi->qi_pquotaip = NULL;
 	}
 	mutex_destroy(&qi->qi_quotaofflock);
+	mutex_destroy(&qi->qi_tree_lock);
 	kmem_free(qi);
 	mp->m_quotainfo = NULL;
 }
-- 
2.15.1