lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 25 Dec 2017 01:54:32 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     kbuild-all@...org, nsekhar@...com, khilman@...nel.org,
        linux@...linux.org.uk, kaloz@...nwrt.org, khalasa@...p.pl,
        aaro.koskinen@....fi, tony@...mide.com, jason@...edaemon.net,
        andrew@...n.ch, sebastian.hesselbarth@...il.com,
        gregory.clement@...e-electrons.com, daniel@...que.org,
        haojian.zhuang@...il.com, robert.jarzmik@...e.fr,
        marek.vasut@...il.com, slapin@...fans.org, jic23@....ac.uk,
        kgene@...nel.org, krzk@...nel.org, ralf@...ux-mips.org,
        ysato@...rs.sourceforge.jp, dalias@...c.org, tglx@...utronix.de,
        mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/11] ARM: pxa: constify gpio_led

Hi Arvind,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on arm-soc/for-next]
[also build test ERROR on v4.15-rc5 next-20171222]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Arvind-Yadav/constify-gpio_led/20171223-142117
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git for-next
config: arm-pxa_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All error/warnings (new ones prefixed by >>):

>> arch/arm/mach-pxa/balloon3.c:390:8: error: expected '{' before 'const'
    struct const gpio_led balloon3_gpio_leds[] __initconst = {
           ^~~~~
>> arch/arm/mach-pxa/balloon3.c:405:11: error: 'balloon3_gpio_leds' undeclared here (not in a function); did you mean 'balloon3_gpio_led_info'?
     .leds  = balloon3_gpio_leds,
              ^~~~~~~~~~~~~~~~~~
              balloon3_gpio_led_info
   In file included from include/linux/kernel.h:15:0,
                    from include/linux/list.h:9,
                    from include/linux/kobject.h:20,
                    from include/linux/device.h:17,
                    from include/linux/platform_device.h:14,
                    from arch/arm/mach-pxa/balloon3.c:18:
>> include/linux/build_bug.h:30:45: error: bit-field '<anonymous>' width not an integer constant
    #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); }))
                                                ^
   include/linux/compiler-gcc.h:65:28: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
    #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
                               ^~~~~~~~~~~~~~~~~
   include/linux/kernel.h:71:59: note: in expansion of macro '__must_be_array'
    #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
                                                              ^~~~~~~~~~~~~~~
>> arch/arm/mach-pxa/balloon3.c:406:14: note: in expansion of macro 'ARRAY_SIZE'
     .num_leds = ARRAY_SIZE(balloon3_gpio_leds),
                 ^~~~~~~~~~
--
>> arch/arm/mach-pxa/palmld.c:249:8: error: expected '{' before 'const'
    struct const gpio_led gpio_leds[] __initconst = {
           ^~~~~
>> arch/arm/mach-pxa/palmld.c:262:11: error: 'gpio_leds' undeclared here (not in a function); did you mean 'gpio_led'?
     .leds  = gpio_leds,
              ^~~~~~~~~
              gpio_led
   In file included from include/linux/kernel.h:15:0,
                    from include/linux/list.h:9,
                    from include/linux/kobject.h:20,
                    from include/linux/device.h:17,
                    from include/linux/platform_device.h:14,
                    from arch/arm/mach-pxa/palmld.c:17:
>> include/linux/build_bug.h:30:45: error: bit-field '<anonymous>' width not an integer constant
    #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); }))
                                                ^
   include/linux/compiler-gcc.h:65:28: note: in expansion of macro 'BUILD_BUG_ON_ZERO'
    #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
                               ^~~~~~~~~~~~~~~~~
   include/linux/kernel.h:71:59: note: in expansion of macro '__must_be_array'
    #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
                                                              ^~~~~~~~~~~~~~~
>> arch/arm/mach-pxa/palmld.c:263:14: note: in expansion of macro 'ARRAY_SIZE'
     .num_leds = ARRAY_SIZE(gpio_leds),
                 ^~~~~~~~~~

vim +390 arch/arm/mach-pxa/balloon3.c

   389	
 > 390	struct const gpio_led balloon3_gpio_leds[] __initconst = {
   391		{
   392			.name			= "balloon3:green:idle",
   393			.default_trigger	= "heartbeat",
   394			.gpio			= BALLOON3_GPIO_LED_IDLE,
   395			.active_low		= 1,
   396		}, {
   397			.name			= "balloon3:green:nand",
   398			.default_trigger	= "nand-disk",
   399			.gpio			= BALLOON3_GPIO_LED_NAND,
   400			.active_low		= 1,
   401		},
   402	};
   403	
   404	static struct gpio_led_platform_data balloon3_gpio_led_info = {
 > 405		.leds		= balloon3_gpio_leds,
 > 406		.num_leds	= ARRAY_SIZE(balloon3_gpio_leds),
   407	};
   408	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32746 bytes)

Powered by blists - more mailing lists