linux-kernel - Re: [PATCH] perf tool: Return all events as auto-completions after comma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Dec 2017 10:57:48 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     jolsa@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH] perf tool: Return all events as auto-completions after
 comma


> One other thing you may want to look at:
> 
>    $ $ perf record -e cycles/<TAB>
> 
> Should present the modifiers, i.e. these:
> 
> /*
>   * Update according to parse-events.l
>   */
> static const char *config_term_names[__PARSE_EVENTS__TERM_TYPE_NR] = {
>          [PARSE_EVENTS__TERM_TYPE_USER]                  = "<sysfs term>",
>          [PARSE_EVENTS__TERM_TYPE_CONFIG]                = "config",
>          [PARSE_EVENTS__TERM_TYPE_CONFIG1]               = "config1",
>          [PARSE_EVENTS__TERM_TYPE_CONFIG2]               = "config2",
>          [PARSE_EVENTS__TERM_TYPE_NAME]                  = "name",
>          [PARSE_EVENTS__TERM_TYPE_SAMPLE_PERIOD]         = "period",
>          [PARSE_EVENTS__TERM_TYPE_SAMPLE_FREQ]           = "freq",
>          [PARSE_EVENTS__TERM_TYPE_BRANCH_SAMPLE_TYPE]    = "branch_type",
>          [PARSE_EVENTS__TERM_TYPE_TIME]                  = "time",
>          [PARSE_EVENTS__TERM_TYPE_CALLGRAPH]             = "call-graph",
>          [PARSE_EVENTS__TERM_TYPE_STACKSIZE]             = "stack-size",
>          [PARSE_EVENTS__TERM_TYPE_NOINHERIT]             = "no-inherit",
>          [PARSE_EVENTS__TERM_TYPE_INHERIT]               = "inherit",
>          [PARSE_EVENTS__TERM_TYPE_MAX_STACK]             = "max-stack",
>          [PARSE_EVENTS__TERM_TYPE_OVERWRITE]             = "overwrite",
>          [PARSE_EVENTS__TERM_TYPE_NOOVERWRITE]           = "no-overwrite",
>          [PARSE_EVENTS__TERM_TYPE_DRV_CFG]               = "driver-config",
> };
> 
> :-)
> 
> - Arnaldo
> 

Hi Arnaldo,

Currently, in my understanding, the modifiers appended to an event are:

u/k/h/I/G/H/p/...

For example,
perf stat -e cycles:u

Does perf support the modifiers like "cycles/config" or 
"cycles/config1", or ..., "cycles/driver-config" now?

I tried some command lines but they were failed. Maybe my used format 
was not correct.

Or do you mean the format like "cpu/xxx"? For example,
perf stat -e cpu/event=0x0e,umask=0x1,inv/ -a sleep 1

Anyway, if we want to implement the auto-completion for the modifiers, 
it'd better expose them by an interface (e.g. perf list --xx) rather 
than hardcode them in auto-completion script. That's my initial idea.

Thanks
Jin Yao