linux-kernel - [PATCH] usb: dwc3: gadget: decrease the queued

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Dec 2017 03:41:28 +0000
From:   Lipengcheng <lpc.li@...ilicon.com>
To:     "balbi@...nel.org" <balbi@...nel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Lipengcheng <lpc.li@...ilicon.com>
Subject: [PATCH] usb: dwc3: gadget: decrease the queued_requests in removal

In removal requests, it is necessary to make the corresponding trb
disable state (HWO = 1) and dep->queued_requests a corresponding reduction.
It is better to use a alone funtion to disable trb (HWO = 0).

Signed-off-by: Pengcheng Li <lpc.li@...ilicon.com>
---
drivers/usb/dwc3/gadget.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 1e6c42e..273b51d 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -707,6 +707,36 @@ static void dwc3_remove_requests(struct dwc3 *dwc, struct dwc3_ep *dep)
    while (!list_empty(&dep->started_list)) {
        req = next_request(&dep->started_list);

+       if (req->trb) {
+           if (req->num_pending_sgs) {
+               struct dwc3_trb *trb;
+               int i = 0;
+
+               for (i = 0; i < req->num_pending_sgs; i++) {
+                   trb = req->trb + i;
+                   trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
+                   dwc3_ep_inc_deq(dep);
+               }
+
+               if (req->unaligned || req->zero) {
+                   trb = req->trb + req->num_pending_sgs + 1;
+                   trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
+                   dwc3_ep_inc_deq(dep);
+               }
+           } else {
+               struct dwc3_trb *trb = req->trb;
+
+               trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
+               dwc3_ep_inc_deq(dep);
+
+               if (req->unaligned || req->zero) {
+                   trb = req->trb + 1;
+                   trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
+                   dwc3_ep_inc_deq(dep);
+               }
+           }
+       }
+       dep->queued_requests--;
        dwc3_gadget_giveback(dep, req, -ESHUTDOWN);
    }

--
2.7.4