linux-kernel - Re: [PATCH] vfio: mdev: make a couple of functions and structure vfio_mdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4cde235-44c7-7192-d1da-897a74db9e16@gmail.com>
Date:   Mon, 25 Dec 2017 13:52:32 +0800
From:   Quan Xu <quan.xu0@...il.com>
To:     Xiongwei Song <sxwjean@...il.com>, kwankhede@...dia.com,
        alex.williamson@...hat.com
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfio: mdev: make a couple of functions and structure
 vfio_mdev_driver static



On 2017/12/22 07:12, Xiongwei Song wrote:
> The functions vfio_mdev_probe, vfio_mdev_remove and the structure
> vfio_mdev_driver are only used in this file, so make them static.
>
> Clean up sparse warnings:
> drivers/vfio/mdev/vfio_mdev.c:114:5: warning: no previous prototype
> for 'vfio_mdev_probe' [-Wmissing-prototypes]
> drivers/vfio/mdev/vfio_mdev.c:121:6: warning: no previous prototype
> for 'vfio_mdev_remove' [-Wmissing-prototypes]
>
> Signed-off-by: Xiongwei Song <sxwjean@...il.com>
> ---
>   drivers/vfio/mdev/vfio_mdev.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
> index fa848a701b8b..d230620fe02d 100644
> --- a/drivers/vfio/mdev/vfio_mdev.c
> +++ b/drivers/vfio/mdev/vfio_mdev.c
> @@ -111,19 +111,19 @@ static const struct vfio_device_ops vfio_mdev_dev_ops = {
>   	.mmap		= vfio_mdev_mmap,
>   };
>   
> -int vfio_mdev_probe(struct device *dev)
> +static int vfio_mdev_probe(struct device *dev)
>   {
>   	struct mdev_device *mdev = to_mdev_device(dev);
>   
>   	return vfio_add_group_dev(dev, &vfio_mdev_dev_ops, mdev);
>   }
>   
> -void vfio_mdev_remove(struct device *dev)
> +static void vfio_mdev_remove(struct device *dev)
>   {
>   	vfio_del_group_dev(dev);
>   }
>   
> -struct mdev_driver vfio_mdev_driver = {
> +static struct mdev_driver vfio_mdev_driver = {
>   	.name	= "vfio_mdev",
>   	.probe	= vfio_mdev_probe,
>   	.remove	= vfio_mdev_remove,
Reviewed-by: Quan Xu <quan.xu0@...il.com>