linux-kernel - Re: [regression] Re: Thinkpad T40p: suspend to ram stopped working sometime before 4.14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171225100514.GB246@x4>
Date:   Mon, 25 Dec 2017 11:05:14 +0100
From:   Markus Trippelsdorf <markus@...ppelsdorf.de>
To:     Pavel Machek <pavel@....cz>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        gregkh@...uxfoundation.org, kyle@...nel.org,
        akpm@...ux-foundation.org, mmarek@...e.com,
        yamada.masahiro@...ionext.com, dwmw2@...radead.org,
        torvalds@...ux-foundation.org,
        kernel list <linux-kernel@...r.kernel.org>,
        len.brown@...el.com, linux-pm@...r.kernel.org
Subject: Re: [regression] Re: Thinkpad T40p: suspend to ram stopped working
 sometime before 4.14

On 2017.12.25 at 10:54 +0100, Pavel Machek wrote:
> On Mon 2017-12-25 09:47:48, Markus Trippelsdorf wrote:
> > On 2017.12.24 at 23:37 +0100, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > > > > > 4.15-rcX is broken, but that had other problems so lets not go there.
> > > > > > > > 
> > > > > > > > 4.14 is broken.
> > > > > > > 
> > > > > > > And what exactly does happen?
> > > > > > 
> > > > > > Suspend looks ok. I believe there's some reaction to power button, but
> > > > > > screen stays blank. I'll re-check that.. I'm in the middle of bisect
> > > > > > now.
> > > > > 
> > > > > Ok, so suspend looks ok. On resume, "moon" LED goes off and power /
> > > > > bluetooth LEDs go on, but screen is black and no response to
> > > > > > > > anything.
> > > > 
> > > > And it seems bad commit is
> > > > 
> > > > commit 5620a0d1aacd554ebebcff373e31107bb1ef7769
> > > > Author: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > > Date:   Thu Sep 14 14:23:01 2017 -0700
> > > > 
> > > >     firmware: delete in-kernel firmware
> > > > 
> > > > Unfortuantely, it does not revert cleanly.
> > > 
> > > I can't, because there's df85b2d767aad90fd2746f993fcd66dd322768f8 on
> > > top of it, partialy reverting it. Seems like 5620 was causing problems
> > > for other people before.
> > > 
> > > And then there's huge mega-patch called "license cleanup" on top of
> > > that, which changes 11100 files (!) and makes work harder still.
> > > 
> > > Can we go for full revert?
> > 
> > No, it does not make any sense. 
> > Could you please post your config? 
> 
> Well.. neither makes the original commit message any sense :-(.
> 
> CONFIG_PREVENT_FIRMWARE_BUILD=y
> CONFIG_FW_LOADER=y
> CONFIG_FIRMWARE_IN_KERNEL=y
> CONFIG_EXTRA_FIRMWARE="radeon/R700_rlc.bin iwlwifi-1000-5.ucode"
> CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware"

Looks like a pilot error to me. You have a R200 card, but you load R700
firmware. Try:
CONFIG_EXTRA_FIRMWARE="radeon/R200_cp.bin iwlwifi-1000-5.ucode"
instead.

-- 
Markus